@meship-starkware reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware and @Yoni-Starkware)

crates/starknet_os_flow_tests/src/tests.rs line 424 at r4 (raw file):

            })
            .or_insert_with(|| HashMap::from([(key, value)]));
    };

Why, as an inline function, is it only relevant for this test?

Code quote:

    let mut update_expected_storage = |address: ContractAddress, key: Felt, value: Felt| {
        let key = StarknetStorageKey(StorageKey(key.try_into().unwrap()));
        let value = StarknetStorageValue(value);
        expected_storage_updates
            .entry(address)
            .and_modify(|map| {
                map.insert(key, value);
            })
            .or_insert_with(|| HashMap::from([(key, value)]));
    };

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware, @meship-starkware, and @Yoni-Starkware)

crates/starknet_os_flow_tests/src/tests.rs line 424 at r4 (raw file):

yes, IIRC I didn't have use for this in another test, though I may be wrong... if I am please block me, I'll extract into a shared util.
also, inlining this means I don't have to inject expected_storage_updates as a parameter

Reviewable status: complete! all files reviewed, all discussions resolved

crates/starknet_os_flow_tests/src/tests.rs line 424 at r4 (raw file):

I took a look at the test, and it seems like this is the only one with a large storage update, except for meta tx, but this function will not help there. So I think we can keep it as is